Skip to content

fix: PHPStan $cols not defined in CLI #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix: PHPStan $cols not defined in CLI #6994

merged 1 commit into from
Dec 20, 2022

Conversation

@ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Dec 20, 2022

Description

------ --------------------------------------
  Line   system\CLI\CLI.php
 ------ --------------------------------------
  :987   Variable $cols might not be defined.
 ------ --------------------------------------

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr changed the title fix: phpstan not defined in CLI fix: PHPStan $cols not defined in CLI Dec 20, 2022
@ddevsr ddevsr requested a review from kenjis December 20, 2022 04:13
@kenjis kenjis added the refactor Pull requests that refactor code label Dec 20, 2022
@ddevsr ddevsr mentioned this pull request Dec 20, 2022
Merged
5 tasks
datamweb
datamweb approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks🥀

@samsonasik samsonasik merged commit 66e0061 into codeigniter4:develop Dec 20, 2022
@ddevsr ddevsr deleted the fix-phpstan-cols-cli branch December 20, 2022 04:31
@samsonasik
Copy link
Member

samsonasik commented Dec 20, 2022

Thank you @ddevsr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

+1 more reviewer

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddevsr @samsonasik @kenjis @datamweb